feat(cdc): amortize snapshot read to multiple barriers #16349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
changed the title
StrikeW
changed the title
9 tasks
|
Can you describe the background/motivation? |
To implement this RFC we discussed before. |
StrikeW
commented
Apr 26, 2024
| @@ -69,6 +71,11 @@ pub struct CdcBackfillExecutor<S: StateStore> { | |||
| rate_limit_rps: Option<u32>, | |||
|
|
|||
| disable_backfill: bool, | |||
|
|
|||
| // TODO: make these options configurable | |||
There was a problem hiding this comment.
Will be done in #16426
| @@ -98,6 +98,8 @@ impl ExecutorBuilder for StreamCdcScanExecutorBuilder { | |||
| state_table, | |||
| node.rate_limit, | |||
| disable_backfill, | |||
| 1, | |||
There was a problem hiding this comment.
snapshot_interval will default to 1, and we allow user to config different value in WITH clause #16426
fuyufjh
reviewed
Apr 26, 2024
|
Evaluated, the barrier doesn't pile up with interval = 5 barriers. Right image is the baseline (1.8.1-rc). 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
We ensure to poll the snapshot stream at least once in each epoch previously, which may cause barrier pile up in some scenario (#15812)
This PR implement the RFC to allow reconstruct a new snapshot stream in each
snapshot_intervalbarriers, trying to mitigate the barrier pile up problem.snapshot_intervalto configure the barrier interval to start a new snapshotsnapshot_read_full_tableto read all historical data in batches to simplify main logicfollow-up: #16426
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.